Update FilteredAsset to support site_id in Nexpose 5.13 and later #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Add site_ids attribute, array of 1 or more site IDs -Change site_id to get first ID from site_ids Note that consoles which do not have Asset Linking enabled can use site_id without any issues. However, consoles with Asset Linking enabled should use site_ids instead.
Saved some lines by using map. Removed an extra space from comment.
sgreen-r7
added a commit
that referenced
this pull request
Jul 7, 2015
Update FilteredAsset to support site_id in Nexpose 5.13 and later
|
ლ(́◉◞౪◟◉‵ლ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #178.
Note that consoles which do not have Asset Linking enabled can use site_id without any issues. However, consoles with Asset Linking enabled should use site_ids instead because site_id may not be the "correct" or expected site_id, depending on the order they are returned.
This will require a version bump to 1.3.0.
Note that all nexpose-client gem versions since 1.0.0 are not backwards-compatible with Nexpose versions prior to 5.13.0.
Testing done: