Add methods to retrieve paused scans #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @site_id = json['Site ID'] | ||
| @status = CompletedScan._parse_status(json['Status Code']) | ||
| @start_time = Time.at(json['Started'].to_i / 1000) | ||
| @end_time = Time.at(json['Progress'].to_i / 1000) |
There was a problem hiding this comment.
Do not use Time.at without zone. Use one of Time.zone.at, Time.at.current, Time.at.in_time_zone, Time.at.utc, Time.at.getlocal, Time.at.iso8601, Time.at.jisx0301, Time.at.rfc3339, Time.at.to_i, Time.at.to_f instead.
gschneider-r7
force-pushed
the
paused_scans_listing
branch
from
8e5edff
to
3bf1ed4
Compare
Two separate methods for site scans and all scans using two different data table endpoints. Added new class ActiveScan based on CompletedScan to handle parsing the data differently.
Forgot to map the global paused scans to ActiveScan objects. Cleaned up doc a bit. Make site_id not default to nil since it is required for the method.
| end | ||
| else | ||
| uri = '/data/site/scans/dyntable.xml?printDocType=0&tableID=siteScansTable&activeOnly=true' | ||
| data = DataTable._get_dyn_table(self, uri).select { |scan| (scan['Status'].include? 'Paused')} |
gschneider-r7
added a commit
that referenced
this pull request
Dec 11, 2015
Add methods to retrieve paused scans
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two separate methods for site scans and all scans using two different data table endpoints. This may or may not allow for some more efficiency when checking specific sites.
Added new class ActiveScan based on CompletedScan to handle parsing the data differently.
Testing required:
A pre-built gem can be downloaded at http://gavinws.com/nexpose-2.3.0.pre.gem otherwise set your gemfile to use my fork and branch.
Resolves #193