Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce PR and Issue templates, move contributing doc #247

Merged
merged 2 commits into from
Sep 14, 2016

Conversation

gschneider-r7
Copy link
Contributor

@gschneider-r7 gschneider-r7 commented Sep 10, 2016

Description

This change adds automatic templates for pull requests and issues. This PR description was created using the template (gotta dogfood it after all). The templates, along with the CONTRIBUTING.md file, are placed in the .github directory to reduce clutter in the project root.

These templates were generated with Issue and Pull Request Template Generator - Github repo.

Motivation and Context

Issues and pull requests should be consistent when possible. This should make it easier to read through them quickly. Additionally, submitters should have an easier time knowing what to fill out. That said these templates are by no means required - a submitter can always clear everything out and write a description from scratch.

How Has This Been Tested?

N/A - just need feedback from other contributors and users. 😄

Screenshots (if appropriate):

screen shot 2016-09-09 at 6 27 42 pm

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the documentation accordingly (if changes are required).
  • I have added tests to cover my changes.
  • All new and existing tests passed.

<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Task lists add up in the PR summary screen as a progress bar. Maybe use a regular bulleted list here to not overload it with IMO meaningless "TODOs"?

screen shot 2016-09-10 at 14 29 32

I think using GitHub task lists for the checklist section below makes sense since they're post-merge steps.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made changes to make this more useful. Also updated the description here to reflect the example usage.

@sgreen-r7
Copy link
Contributor

👻

@sgreen-r7 sgreen-r7 merged commit 5e3b6cd into master Sep 14, 2016
@sgreen-r7 sgreen-r7 deleted the github_stuff branch September 14, 2016 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants