Only Cleanup! #292
Merged
Only Cleanup! #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 6, 2017
| @loginURL = loginURL | ||
| @name = name | ||
| @baseURL = baseURL | ||
| @loginURL = loginURL |
| @baseURL = baseURL | ||
| @loginURL = loginURL | ||
| @name = name | ||
| @baseURL = baseURL |
| @baseURL = baseURL | ||
| @headers = {} | ||
| @name = name | ||
| @baseURL = baseURL |
| @@ -4,22 +4,21 @@ module Nexpose | |||
| module WebCredentials | |||
|
|
|||
| module WebAppAuthType | |||
| HTML_FORM = 'htmlform' # Represent HTML form credentials. | |||
| HTML_FORM = 'htmlform' # Represent HTML form credentials. | |||
There was a problem hiding this comment.
Freeze mutable objects assigned to constants.
| ALL_INSTANCES_IN_A_SPECIFIC_SITE = 'All Instances in a Specific Site' | ||
| ALL_INSTANCES = 'All Instances' | ||
| ALL_INSTANCES_ON_A_SPECIFIC_ASSET = 'All Instances on a Specific Asset' | ||
| ALL_INSTANCES_IN_A_SPECIFIC_SITE = 'All Instances in a Specific Site' |
There was a problem hiding this comment.
Freeze mutable objects assigned to constants.
| end | ||
|
|
||
| # The reason for the exception status. | ||
| # | ||
| module Reason | ||
| FALSE_POSITIVE = 'False Positive' | ||
| FALSE_POSITIVE = 'False Positive' |
There was a problem hiding this comment.
Freeze mutable objects assigned to constants.
| DELETED = 'Deleted' | ||
| APPROVED = 'Approved' | ||
| REJECTED = 'Rejected' | ||
| DELETED = 'Deleted' |
There was a problem hiding this comment.
Freeze mutable objects assigned to constants.
| REJECTED = 'Rejected' | ||
| DELETED = 'Deleted' | ||
| APPROVED = 'Approved' | ||
| REJECTED = 'Rejected' |
There was a problem hiding this comment.
Freeze mutable objects assigned to constants.
| APPROVED = 'Approved' | ||
| REJECTED = 'Rejected' | ||
| DELETED = 'Deleted' | ||
| APPROVED = 'Approved' |
There was a problem hiding this comment.
Freeze mutable objects assigned to constants.
| Nexpose::VulnException::Status.const_get(name).to_s.downcase==status.downcase || status.to_sym.downcase == name.downcase | ||
| end | ||
| def status_string_to_constant(status) | ||
| Nexpose::VulnException::Status.constants.find do |name| |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should just be non-breaking changes, formatting fixes, and general TLC.
rubocop --format simple -F