-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify HTTP and UPnP Server header fingerprinting #218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need to get Nexpose updated for this change
Are there any concerns about the loss of the |
For Metasploit, it doesn't care about the protocol field, but MDM is hard-wired for the upnp_banners.xml. This is an easy fix on the MDM side: https://github.com/rapid7/metasploit_data_models/blob/master/lib/mdm/host/operating_system_normalization.rb#L222 |
@tsellers-r7 yes, it is somewhat unfortunate that we are losing this, but other than private/personal code I don't believe any integrating products are currently using the |
Thanks for the reminder on MDM @hdm, I've opened rapid7/metasploit_data_models#175 |
Description
I've removed the UPnP database (hence the version bump) and moved it as is (minus the recently added Sonos fingerprints, which would be duplicate) to the HTTP Server header fingerprinting because for our purposes these are the same protocols and keeping them separate only causes maintenance headaches.
Motivation and Context
Drastically improve HTTP and UPnP coverage while simplifying maintenance.
How Has This Been Tested?
rspec
passesI also used the most recent set of HTTP and UPnP study data from recog to see if/how fingerprinting would improve. Previously using the HTTP Server fingerprint against the HTTP studies failed to matched 37074 unique Server headers, and after this change it failed to match 34994. Given that each unique header generally corresponds to several IPs, the actual impact is much larger than the difference of 2080 implies.
Types of changes
Checklist: