Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCA-17412: Updated SonicOS recog fingeprint #240

Merged
merged 4 commits into from
Oct 11, 2019
Merged

Conversation

jheysel-r7
Copy link
Contributor

@jheysel-r7 jheysel-r7 commented Oct 11, 2019

Description

Updated the SonicOS fingerprinter so we can capture the hardware model version separately from the hardware model name

Motivation and Context

Explanation of why these changes are being proposed, including any links to other relevant issues or pull requests.

How Has This Been Tested?

New Fingerprint matches all examples given as expected:

Match # Group index Start index End index Group content
1 0 0 58 SonicWALL SuperMassive 9200 (SonicOS Enhanced 6.2.5.3-35n)
1 1 10 22 SuperMassive
1 2 23 27 9200
1 3 46 57 6.2.5.3-35n

Rake tests pass

9 scenarios (9 passed)
20 steps (20 passed)
0m2.782s

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

xml/snmp_sysdescr.xml Outdated Show resolved Hide resolved
xml/snmp_sysdescr.xml Outdated Show resolved Hide resolved
<param pos="0" name="os.vendor" value="SonicWall"/>
<param pos="0" name="os.device" value="Firewall"/>
<param pos="0" name="os.family" value="SonicOS"/>
<param pos="1" name="os.product"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on a review of SonicWall's offerings it looks like we should have a line that statically sets the os.product value.

<param pos="0" name="os.product" value="SonicOS"/>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, changes made, tests pass

@tsellers-r7 tsellers-r7 merged commit 74983c2 into master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants