Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitespace cleanup/interpolation changes #247

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Whitespace cleanup/interpolation changes #247

merged 1 commit into from
Nov 13, 2019

Conversation

tsellers-r7
Copy link
Contributor

@tsellers-r7 tsellers-r7 commented Nov 13, 2019 •
edited
Loading

Description

This PR

  • Changes os.cpe23 in ssh_banners.xml to use {os.version} instead of static strings where possible.
  • Cleans up a few whitespace issues

Motivation and Context

Code consistency and to reduce copy/paste errors by removing static strings in favor of interpolation.

How Has This Been Tested?

rspec

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

@tsellers-r7 tsellers-r7 merged commit 32306a4 into rapid7:master Nov 13, 2019
@tsellers-r7 tsellers-r7 deleted the ssh_formatting branch November 13, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdeardorff-r7 pdeardorff-r7 pdeardorff-r7 approved these changes

@rhodgman-r7 rhodgman-r7 Awaiting requested review from rhodgman-r7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsellers-r7 @pdeardorff-r7