Add extraction tests for ssh_banners #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds extract tests for examples in
xml/ssh_banners.xmlwith the goal of ensuring that we capture what we expect to capture. This change leverages the new test added by @rhodgman-r7 in PR #244 for detecting when a fingerprint doesn't have any examples that validate a particular capture such asservice.version.There were 3 or 4 banners with no examples. I verified that I was unable to find any examples of these banners from recent Sonar studies.
Motivation and Context
Improved testing
How Has This Been Tested?
rspecrake testsbin/recog_verify xml/ssh_banners.xmlTypes of changes
Checklist: