Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of recent fingerprint changes & additions #254

Closed
wants to merge 14 commits into from
Closed

Rollup of recent fingerprint changes & additions #254

wants to merge 14 commits into from

Conversation

hdm
Copy link
Contributor

@hdm hdm commented Feb 19, 2020

Description

This is a roll-up PR of changes we have accumulated since December. The big ones:

  1. Rename Terminal Server to Device Server for consistency across fingerprints.
  2. Major updates to IP Phone, VoIP bridges, and video conferencing signatures
  3. A scattering of small typo fixes and signature improvements
  4. Clarification that the http_servers.xml is also used for SIP and RTSP
  5. Fix missing NetScaler/Pulse VPN detection by HTTP Cookie

Motivation and Context

Consistency and improved coverage across the board

How Has This Been Tested?

Real-world testing (shipping in Rumble since December) along with rspec and the recog_verify script.

Types of changes

See above

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

@hdm hdm mentioned this pull request Feb 19, 2020
3 tasks
@hdm
Copy link
Contributor Author

hdm commented Feb 19, 2020

Closing this for now, will re-pull as a sip_banners.xml PR and then a second for RTSP and the others.

@hdm hdm closed this Feb 19, 2020
@hdm hdm deleted the updates/20200219 branch April 2, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant