DNS: Windows Server 2008 SP2, performance and other coverage tweaks #276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds coverage for an additional DNS fingerprint of DNS running on Microsoft Windows 2008 SP2. There are other misc DNS tweaks as well and some performance related changes.
The main thing I'm concerned about is the 'assert nothing' results that end up assigning a
service.protocol
value which is inherited from the XML database.I'm addressing this by setting
service.certainty
to `0.0. It this logic makes sense we can apply it elsewhere when the same assert nothing style matches are used.Motivation and Context
Coverage
How Has This Been Tested?
rspec
, local testingTypes of changes
Checklist: