Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS: Windows Server 2008 SP2, performance and other coverage tweaks #276

Merged
merged 4 commits into from
Jul 15, 2020

Conversation

tsellers-r7
Copy link
Contributor

@tsellers-r7 tsellers-r7 commented Jul 14, 2020

Description

This PR adds coverage for an additional DNS fingerprint of DNS running on Microsoft Windows 2008 SP2. There are other misc DNS tweaks as well and some performance related changes.

The main thing I'm concerned about is the 'assert nothing' results that end up assigning a service.protocol value which is inherited from the XML database.

$ echo '' | bin/recog_match xml/dns_versionbind.xml 

MATCH: {
  "matched"=>"empty string -- assert nothing.", 
  "service.protocol"=>"dns", 
  "fingerprint_db"=>"dns.versionbind", 
  "data"=>""}

I'm addressing this by setting service.certainty to `0.0. It this logic makes sense we can apply it elsewhere when the same assert nothing style matches are used.

$ echo '' | bin/recog_match xml/dns_versionbind.xml 

MATCH: {
  "matched"=>"empty string -- assert nothing.", 
  "service.certainty"=>"0.0", 
  "service.protocol"=>"dns",
  "fingerprint_db"=>"dns.versionbind", 
  "data"=>""}

Motivation and Context

Coverage

How Has This Been Tested?

rspec, local testing

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

@tsellers-r7 tsellers-r7 requested review from a user, gwiseman-r7, rkirk-r7 and bcook-r7 July 14, 2020 22:49
xml/dns_versionbind.xml Outdated Show resolved Hide resolved
@tsellers-r7 tsellers-r7 merged commit 971a234 into rapid7:master Jul 15, 2020
@tsellers-r7 tsellers-r7 deleted the dns_updates branch July 15, 2020 11:37
@tsellers-r7 tsellers-r7 changed the title DNS tweaks DNS: Windows Server 2008 SP2, performance and other coverage tweaks Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants