DNS: Avoid spoofed Microsoft DNS Server, add Debian Buster #277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR handles a spoofed DNS version bind response as well as adds coverage for Debian Buster.
The PR adds a fingerprint to assert nothing for a particular DNS
version.bind
response that claims to be Microsoft DNS server but isn't. The comment should explain the details. I tested using a quirk in how Microsoft handlesversion.bind
queries. They respond to lowercase version.bind queries but not uppercase queries. Pretty much everyone else handles the query in a case insensitive way. I sampled the servers reportingMicrosoft DNS 6.0.6100 (2AEF76E)
and was unable to find one that was actually a Microsoft DNS server.Actual Microsoft DNS server response:
Spoofed response
Here's an article where that version string shows up: https://raymii.org/s/tutorials/Get_DNS_server_version_and_hide_it_in_BIND.html
Motivation and Context
Improved accuracy and coverage.
How Has This Been Tested?
rspec
, local tests.Types of changes
Checklist: