-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sonar / CPE updates #279
Sonar / CPE updates #279
Conversation
@@ -463,6 +505,7 @@ more text</example> | |||
<example service.version="0.9.13a beta">FileZilla Server version 0.9.13a beta</example> | |||
<example service.version="0.9.54 beta">FileZilla Server 0.9.54 beta</example> | |||
<example service.version="0.9.33 beta">FileZilla Server v0.9.33 beta</example> | |||
<param pos="0" name="service.vendor" value="Filezilla-Project"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no NIST issued CPE value for the Filezilla FTP server. This change just aligns with vendor value with the vendor in the existing NIST CPEs for the client.
Update: I have reached out to NIST about assigning a CPE. I was able to find 6 related CVEs.
@@ -516,6 +516,7 @@ | |||
<param pos="0" name="service.family" value="NSD"/> | |||
<param pos="0" name="service.product" value="dnsd"/> | |||
<param pos="1" name="service.version"/> | |||
<param pos="0" name="service.cpe23" value="cpe:/a:nlnetlabs:name_server_daemon:{service.version}"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change alone, via the cpe-remap change, added CPEs for over a million matches from our recent DNS study and so I wanted to get it in now.
Description
This PR:
service.vendor
and/orservice.product
where necessary to enable CPE auto-generation using NIST issued CPE values. This significantly improves the number of services on the Internet that we will have CPEs for. For example, from recent Project Sonar FTP studies the following fingerprints did not have CPEs:For
53/udp
DNS data, metrics on fingerprinted services that did not have CPE values:For
25/tcp
SMTP data, metrics on fingerprinted services that did not have CPE values:For
110/tcp
POP3 data, metrics on fingerprinted services that did not have CPE values:For
143/tcp
IMAP data, metrics on fingerprinted services that did not have CPE values:Motivation and Context
Improved coverage
How Has This Been Tested?
rspec
, local testing.Types of changes
Content update
Checklist: