Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Sonar: Moxa and misc #280

Merged
merged 10 commits into from
Aug 2, 2020
Merged

Project Sonar: Moxa and misc #280

merged 10 commits into from
Aug 2, 2020

Conversation

tsellers-r7
Copy link
Contributor

@tsellers-r7 tsellers-r7 commented Jul 30, 2020

Description

This PR improves coverage of Moxa products. It also contains various additions / improvements based on Project Sonar survey data.

Motivation and Context

Coverage improvements.

  • Significant improvements in coverage, from a volume perspective, when testing against Project Sonar data.
  • Coverage for multiple Moxa branded devices
  • Performance tweaks for xml/html_title.xml

How Has This Been Tested?

rspec,
built-in tests via bin/recog_verify
tests against data

Types of changes

  • Coverage

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

@tsellers-r7 tsellers-r7 marked this pull request as ready for review July 30, 2020 19:22
@tsellers-r7 tsellers-r7 requested review from rkirk-r7, gwiseman-r7 and a user July 30, 2020 19:22
@tsellers-r7 tsellers-r7 merged commit b4a5fad into rapid7:master Aug 2, 2020
@tsellers-r7 tsellers-r7 deleted the moxa branch August 2, 2020 12:16
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant