Siemens updates in snmp_sysdescr.xml (tweak PR#286) #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @hdm since you had feedback on the previous PR. |
|
It looks like |
|
Thanks @hdm
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a few issues in PR #286. It also adds some tests to a few of the fingerprints that were missing them.
CC @nstylepro
Motivation and Context
Explanation of why these changes are being proposed, including any links to other relevant issues or pull requests.
How Has This Been Tested?
rspecbin/recog_verify xml/snmp_sysdescr.xmlChecklist: