Added SolarWinds Orion fingerprints #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkirk-r7
reviewed
Jan 4, 2021
| <example>53317933c27890ae9218697ecc0e97d9</example> | ||
| <param pos="0" name="service.vendor" value="SolarWinds"/> | ||
| <param pos="0" name="service.product" value="Orion"/> | ||
| <param pos="0" name="service.certainty" value="0.5"/> |
There was a problem hiding this comment.
Should we add the CPE for both of these fingerprints?
<param pos="0" name="service.cpe23" value="cpe:/a:solarwinds:orion_platform:-"/>
There was a problem hiding this comment.
I've updated both with the CPEs.
rkirk-r7
approved these changes
Jan 12, 2021
|
I'll try to land this later today. I expect that the automatic CPE generation ( https://github.com/rapid7/recog/blob/master/CONTRIBUTING.md#updating-cpes ) will fail so we will either change the name of the product from https://github.com/rapid7/recog/blob/master/cpe-remap.yaml |
|
@scopedsecurity - Landing this now, thanks for the contribution. As a note, I'll likely change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added SolarWinds Orion fingerprints in html_title.xml and favicons.xml