Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPE / example cleanup #349

Merged
merged 2 commits into from
Apr 26, 2021
Merged

CPE / example cleanup #349

merged 2 commits into from
Apr 26, 2021

Conversation

tsellers-r7
Copy link
Contributor

@tsellers-r7 tsellers-r7 commented Apr 26, 2021 •
edited
Loading

Description

This PR includes:

  • General fixup after landing PRs
  • CPE updates with using today's NIST CPE database

Motivation and Context

Quality / consistency.

How Has This Been Tested?

rspec

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

@tsellers-r7 tsellers-r7 mentioned this pull request Apr 26, 2021
Merged
hdm
hdm reviewed Apr 26, 2021
View reviewed changes
xml/ntp_banners.xml Outdated Show resolved Hide resolved
hdm
hdm reviewed Apr 26, 2021
View reviewed changes
xml/http_cookies.xml
<description>Observium</description>
<param pos="1" name="cookie"/>
<param pos="0" name="cookie" value="OBSID"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure of the point of these, do they provide anything useful to the user?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never used them. I've only kept them there for consistency sake. I think Jon added them for cases where the cookie name contains a value that might be useful to the consumer. An example I've seen would be
CF_CLIENT_FOO_CORP=2;Path=/;Expires=Sun, 02-Aug-2020 00:54:53 UTC
wordpress_89ca499ef62aa0b115202a9a7cf04c10=+; expires=Fri, 02-Aug-2019 01:55:35 GMT; path=/
BIGipServer~web~pool_SOMEPOOLNAME=386140170.36895.0000; path=/; Httponly; Secure

@hdm
Copy link
Contributor

hdm commented Apr 26, 2021

Thanks! Looks like one small typo (also in the original fingerprint). Looks good to me, but I was wondering what the point of the cookie name capture is.

@tsellers-r7 tsellers-r7 merged commit 1ca15b6 into rapid7:master Apr 26, 2021
@tsellers-r7 tsellers-r7 deleted the post_land_fixup branch April 26, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdm hdm hdm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsellers-r7 @hdm