Field name standardization #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsellers-r7
commented
Apr 26, 2021
|
|
||
| `fields.txt` defines the various fields (`os.vendor`, etc.) used to assert | ||
| information about a match. | ||
|
|
There was a problem hiding this comment.
The above is the only real change to this file. The rest are just formatting.
tsellers-r7
commented
Apr 26, 2021
| <param pos="1" name="hw.product.model"/> | ||
| <param pos="0" name="hw.product" value="TemPageR {hw.product.model}"/> | ||
| <param pos="1" name="hw.model"/> | ||
| <param pos="0" name="hw.product" value="TemPageR {hw.model}"/> |
There was a problem hiding this comment.
@hdm - RE: These two fingerprints - you added these a while back. I've changed hw.product.model to hw.model to be in keeping with the use of hw.model used elsewhere. Any concerns here?
tsellers-r7
commented
Apr 26, 2021
| @@ -2766,7 +2766,7 @@ | |||
| <param pos="0" name="hw.certainty" value="0.75"/> | |||
| <param pos="0" name="os.vendor" value="Dell"/> | |||
| <param pos="0" name="os.product" value="iDRAC Linux"/> | |||
| <param pos="0" name="os .certainty" value="0.75"/> | |||
| <param pos="0" name="os.certainty" value="0.75"/> | |||
There was a problem hiding this comment.
Already paying off..
|
@hdm - in light of the |
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds field names (
os.vendor,service.product, etc) tobin/recog_standarize. This should help us identify field name typos as well as be a bit more intentional when we introduce a new field.How Has This Been Tested?
ruby bin/recog_standardize xml/*.xml, rspec, etc.Types of changes
Checklist: