Update http_cookies #351
Merged
Update http_cookies #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsellers-r7
commented
Apr 26, 2021
| <fingerprint pattern="^__cfd?uid="> | ||
| <description>CloudFlare web load balancer endpoint</description> | ||
| <example>__cfuid=1337</example> | ||
| <example>__cfduid=dd450f2431e1e611a61a15f68974de9a41618794671; expires=Wed, 19-May-21 01:11:11 GMT; path=/; domain=.foo.bar; HttpOnly; SameSite=Lax</example> |
There was a problem hiding this comment.
Fingerprint moved up due to frequency of observation. Coverage for __cfduid added
tsellers-r7
commented
Apr 26, 2021
| <param pos="0" name="service.cpe23" value="cpe:/a:php:php:-"/> | ||
| </fingerprint> | ||
|
|
||
| <fingerprint pattern="^(ASPSESSIONID[A-Z]+|ASP\.NET_SessionId|\.ASPXANONYMOUS)=.*"> |
There was a problem hiding this comment.
This and above moved up for performance reasons
|
FYI @hdm |
|
Thanks! |
|
This LGTM at first glance. We may want to consider normalizing cookies in the future so that we parse each cookie separately vs the entire Set-Cookie header, as the order of cookies can change. Any anchors (^) might not be valid when there is an application cookie set first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
http_cookiesby:Motivation and Context
Improving fingerprints
How Has This Been Tested?
rspecChecklist: