Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Palo Alto Tweaks #355

Merged
merged 2 commits into from
May 6, 2021
Merged

Palo Alto Tweaks #355

merged 2 commits into from
May 6, 2021

Conversation

tsellers-r7
Copy link
Contributor

@tsellers-r7 tsellers-r7 commented May 5, 2021

Description

This PR tweaks the fields for Palo Alto so as to return better data and/or improve the ability to generate CPEs.

I would have preferred to change PANOS to PAN-OS for the os.product but I wasn't sure what this would break downstream.

I also reset and regenerated the contents of the identifiers/ directory.

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

@tsellers-r7
Copy link
Contributor Author

CC @hdm since I've adjusted some OS values and names.

@hdm
Copy link
Contributor

hdm commented May 5, 2021

Thanks! Looks good to me!

Copy link

@rkirk-r7 rkirk-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nexpose currently expects PAN-OS for product and family so would be a good change for us at least. Could we add os.family field too? Nexpose checks depend on that field.

@tsellers-r7
Copy link
Contributor Author

FYI @hdm we're going ahead with the switch from PANOS to PAN-OS.

@tsellers-r7 tsellers-r7 merged commit d3464ec into rapid7:master May 6, 2021
@tsellers-r7 tsellers-r7 deleted the paloalto_updates branch May 6, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants