Add new database dhcp_vendor_class #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsellers-r7
suggested changes
Jul 26, 2021
There was a problem hiding this comment.
Thanks for the PR @modoyle-r7 . Apologies for the extreme delay in response. I've left some comments. We can discuss them further over slack.
tsellers-r7
reviewed
Jul 26, 2021
Based on vi_vendor_class field in DHCP client discover, request and inform messages. Added sample fingerprints and associated changes to identifiers
|
@modoyle-r7 - I'm going to go ahead and land this PR. Thanks tons for your extreme patience with the delays. @mkienow-r7 is Recog's new owner and once he is up to speed these will be handled in a timely manner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables device identification using broadcast DHCP messages.
Uses strings from the vi_vendor_class field in DHCP client
discover, request and inform messages.
Added sample fingerprints with examples.
Associated changes to the identifiers directory
Checklist: