Field migration: host.id -> hw.serial_number #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsellers-r7
commented
Jul 27, 2021
| @@ -116,7 +116,6 @@ IPReach | |||
| IPSO | |||
| IRIX | |||
| Integrated Lights Out Manager | |||
| Integrated Lights Out Manager firmware | |||
There was a problem hiding this comment.
I rebuilt all of the identifiers/ files. Apparently this value was no longer used.
tsellers-r7
commented
Jul 27, 2021
| @@ -264,84 +264,3 @@ def self.best_service_match(matches) | |||
|
|
|||
| end | |||
| end | |||
|
|
|||
There was a problem hiding this comment.
Out of date comment replaced by the data in the identifiers/ directory
tsellers-r7
commented
Jul 27, 2021
| kace: | ||
| vendor: dell | ||
| products: | ||
| k1000: kace_k1000_systems_management_appliance |
There was a problem hiding this comment.
opportunistic CPE improvement
ekelly-1898
approved these changes
Jul 28, 2021
rkirk-r7
approved these changes
Jul 28, 2021
3 tasks
|
I agree with changing to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the change discussed in Issue #364.
The changes:
host.idtohw.serial_numberwhere the value is a hardware serial numberhost.idtohost.namewhere the value references a host namecisco.serial_numberthat value is duplicated inhw.serial_numberand a test added for it.Motivation and Context
The intent is to add clarity to the data that is captured. The field
host.idwas unclear and was being used to capture hostnames as well as serial numbers.How Has This Been Tested?
rspec, fingerprint example captures.Types of changes
Checklist: