Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify telnet patterns to fix recog-java compatibility #385

Merged

Conversation

mkienow-r7
Copy link
Contributor

@mkienow-r7 mkienow-r7 commented Nov 13, 2021

Description

Small xml/telnet_banners.xml pattern modifications to fix issues with recog-java compatibility.

Motivation and Context

Resolve recog-java fingerprint issues introduced when adding support for base64 encoded examples in rapid7/recog-java#15.

com.rapid7.recog.verify.RecogVerifier failures

xml/telnet_banners.xml: FAIL: 'HP Printer - Jet Direct' failed to match "HP JetDirect
<snip>
" with '^(?:\r|\n)*HP JetDirect(?:\r|\n)+$'
xml/telnet_banners.xml: FAIL: 'HP Printer - Jet Direct' failed to match "HP JetDirect
<snip>
" with '^(?:\r|\n)*HP JetDirect(?:\r|\n)+$'
xml/telnet_banners.xml: FAIL: 'Windows 2000' failed to match "Microsoft (R) Windows NT (TM) Version 4.00 (Build 1381)
<snip>
login: " with '^Telnet Server Build (5.*)'
xml/telnet_banners.xml: WARN: 'Arescom System' is missing an example that checks for parameter 'hw.model' which is derived from a capture group
xml/telnet_banners.xml: FAIL: 'HP ProCurve Switch' failed to match "
<snip>
Username: " with '^HP ([^\s]+) ProCurve Switch'
xml/telnet_banners.xml: SUMMARY: Test completed with 154 successful, 1 warnings, and 4 failures

How Has This Been Tested?

  • rake tests
  • mvn --projects recog-verify exec:java -Dexec.mainClass="com.rapid7.recog.verify.RecogVerifier" -Dexec.args="$(ls -1 xml/*.xml | xargs)"
    ...
    xml/telnet_banners.xml: WARN: 'Arescom System' is missing an example that checks for parameter 'hw.model' which is derived from a capture group
    xml/telnet_banners.xml: SUMMARY: Test completed with 158 successful, 1 warnings, and 0 failures
    ...
    

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

@mkienow-r7 mkienow-r7 merged commit 9e78741 into rapid7:master Nov 15, 2021
@mkienow-r7 mkienow-r7 deleted the bug/modify-patterns-for-recog-java branch November 15, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants