Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify telnet patterns to fix recog-java compatibility (2) #387

Merged

Conversation

mkienow-r7
Copy link
Contributor

@mkienow-r7 mkienow-r7 commented Nov 19, 2021

Description

Small xml/telnet_banners.xml pattern modifications to fix issues with recog-java compatibility.

Motivation and Context

Resolve recog-java fingerprint issues introduced with new fingerprints from #382.

com.rapid7.recog.verify.RecogVerifier failures

$ mvn --projects recog-verify exec:java -Dexec.mainClass="com.rapid7.recog.verify.RecogVerifier" -Dexec.args="--no-warnings xml/telnet_banners.xml"
...

xml/telnet_banners.xml: FAIL: 'Lantronix device server - w/o Serial' failed to match "*** Lantronix UDS1100-IAP Device Server ***
<snip>
" with '(?m)\*\*\* Lantronix ([\S+ ]+) Device Server .{0,1000}MAC address ([a-fA-F0-9]{12}).{0,1000}Software version V(\S+)'

xml/telnet_banners.xml: FAIL: 'Lantronix device server - w/ Serial' failed to match "*** Lantronix Universal Device Server ***
<snip>
" with '(?m)\*\*\* Lantronix Universal Device Server .{0,1000}Serial Number (\d+)\s+MAC address ([a-fA-F0-9:]{17}).{0,1000}Software version (\S+)'
xml/telnet_banners.xml: SUMMARY: Test completed with 171 successful, 0 warnings, and 2 failures

How Has This Been Tested?

  • rake tests
  • mvn --projects recog-verify exec:java -Dexec.mainClass="com.rapid7.recog.verify.RecogVerifier" -Dexec.args="--no-warnings xml/telnet_banners.xml"
    ...
    xml/telnet_banners.xml: SUMMARY: Test completed with 173 successful, 0 warnings, and 0 failures
    

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

@mkienow-r7 mkienow-r7 merged commit da2423f into rapid7:master Nov 19, 2021
@mkienow-r7 mkienow-r7 deleted the bug/modify-patterns-for-recog-java-2 branch November 19, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants