Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CPEs #388

Merged
merged 2 commits into from
Dec 4, 2021
Merged

Update CPEs #388

merged 2 commits into from
Dec 4, 2021

Conversation

mkienow-r7
Copy link
Contributor

@mkienow-r7 mkienow-r7 commented Nov 19, 2021

Description

Cleans up some os and hw parameters, updates CPE values, and cleans up whitespace.

Motivation and Context

Valid CPE values are great!

How Has This Been Tested?

  • rake tests
  • ./bin/recog_verify --no-warnings xml/*.xml

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

xml/html_title.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@tsellers-r7 tsellers-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made a few comments but nothing major.

@mkienow-r7 mkienow-r7 merged commit e4febeb into rapid7:master Dec 4, 2021
@mkienow-r7 mkienow-r7 deleted the bug/cleanup-for-cpes branch December 4, 2021 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants