Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Comware SSH banner #39

Merged
merged 1 commit into from
Mar 6, 2015
Merged

Add Comware SSH banner #39

merged 1 commit into from
Mar 6, 2015

Conversation

alynn71
Copy link
Contributor

@alynn71 alynn71 commented Mar 6, 2015

added Comware SSH banner and successfully tested in Nexpose

@jhart-r7 jhart-r7 self-assigned this Mar 6, 2015
<example os.version="5.20.105">Comware-5.20.105</example>
<example os.version="5.20">Comware-5.20</example>
<param pos="0" name="service.vendor" value="H3C"/>
<param pos="0" name="service.product" value="SSH"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave this here, but in general we try not to list protocols where it should really be a product. Put another way, unless we know for sure that H3C makes their own SSH server (rather than, say, just rebuilding OpenSSH), then we might not want to put SSH here. Based on my quick look at what H3C does, though, keeping SSH here makes more sense than not.

@jhart-r7 jhart-r7 merged commit daa6d76 into rapid7:master Mar 6, 2015
jhart-r7 added a commit that referenced this pull request Mar 6, 2015
jhart-r7 added a commit that referenced this pull request Mar 6, 2015
@jhart-r7
Copy link
Contributor

jhart-r7 commented Mar 6, 2015

Thanks again, @alynn71 .

@alynn71 alynn71 deleted the comware_ssh branch March 17, 2015 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants