Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all examples in apache_os.xml #407

Merged
merged 2 commits into from
Feb 1, 2022
Merged

Conversation

dabdine
Copy link
Contributor

@dabdine dabdine commented Feb 1, 2022

Description

Addresses all warnings in apache_os.xml using real data from Censys.

Motivation and Context

Eliminate warnings due to missing examples.

How Has This Been Tested?

bundle exec rake tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

<param pos="0" name="os.vendor" value="rPath"/>
<param pos="0" name="os.family" value="Linux"/>
<param pos="0" name="os.product" value="Linux"/>
</fingerprint>

<fingerprint pattern="\(StartCom Linux\)">
<description>StartCom Linux</description>
<!-- Replace with a useful (real world) example if one is found -->
<example>Apache (StartCom Linux)</example>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find an example for this, so I just hand-crafted a string to satisfy the regular expression. StartCom appears to be defunct.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a mirror that has ISOs for that distro! https://ftp.nluug.nl/pub/os/Linux/distr/startcom/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call!

$ wget -q https://ftp.nluug.nl/pub/os/Linux/distr/startcom/AS-5.0.0/os/x86_64/StartCom/RPMS/httpd-2.2.3-31.SEL5_4.x86_64.rpm && \
rpm2cpio httpd-2.2.3-31.SEL5_4.x86_64.rpm | cpio -ivdm ./usr/sbin/httpd && \
strings usr/sbin/httpd | grep StartCom && \
rm httpd-2.2.3-31.SEL5_4.x86_64.rpm
./usr/sbin/httpd
6466 blocks
Apache/2.2.3 (StartCom)
Apache/2.2.3 (StartCom) (Release 31.SEL5_4)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ URL="https://ftp.nluug.nl/pub/os/Linux/distr/startcom/ML-5.0.5/os/x86_64/StartCom/RPMS/httpd-2.2.0-5.1.2.x86_64.rpm" FNAME="`basename $URL`" bash -c 'wget -q $URL && rpm2cpio $FNAME | cpio -ivdm ./usr/sbin/httpd && strings usr/sbin/httpd | grep StartCom && rm $FNAME' 
./usr/sbin/httpd
14294 blocks
Apache/2.2.0 (StartCom Linux)

@dabdine
Copy link
Contributor Author

dabdine commented Feb 1, 2022

Force-pushed to remove an outdated comment without having to mangle history too much.

Copy link
Contributor

@mkienow-r7 mkienow-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @dabdine!

@mkienow-r7 mkienow-r7 merged commit f298515 into rapid7:master Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants