-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add phpMyAdmin fingerprints #409
Add phpMyAdmin fingerprints #409
Conversation
xml/html_title.xml
Outdated
<example>phpMyAdmin</example> | ||
<example service.version="2.10.0.2">phpMyAdmin 2.10.0.2</example> | ||
<example service.version="5.0.0-rc1">phpMyAdmin 5.0.0-rc1</example> | ||
<example service.version="5.0.4">10.10.10.10:8080 / db.foo.bar | phpMyAdmin 5.0.4</example> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we extract 10.10.10.10 into a host.ip field like we do elsewhere? Same thing can be said for the host name below, though that's arguably less useful since it can be localhost or something internal (and it would also likely require splitting the regex which i'm not a fan of).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was thinking about doing that. The regex might be a little tricky in that it needs to capture both IPv4, IPv6 and hostnames dropping the :port
portion.
The title is loaded with information '@HTTP_HOST@ / @VSERVER@ | @PHPMYADMIN@'
and also contains the MySQL server name.
From What format strings can I use?
@HTTP_HOST@
HTTP host that runs phpMyAdmin
@VSERVER@
Verbose MySQL server name if set, otherwise normal
affad5b
to
2afea1a
Compare
xml/favicons.xml
Outdated
<fingerprint pattern="^531b63a51234bb06c9d77f219eb25553$"> | ||
<description>phpMyAdmin web interface for MySQL and MariaDB</description> | ||
<example>531b63a51234bb06c9d77f219eb25553</example> | ||
<param pos="0" name="service.vendor" value="phpmyadmin"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and elsewhere for .vendor
and .product
: This should be phpMyAdmin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
2afea1a
to
b4e455c
Compare
Description
Adds 3 phpMyAdmin fingerprints.
Motivation and Context
Fingerprint more services.
How Has This Been Tested?
rake tests
Types of changes
Checklist: