Fix path traversal issue with example filename #421
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes path traversal issue with example
_filename
attribute. Thanks to @dabdine for bringing attention to the issue! In addition, this enhancesbin/recog_verify
to be more resilient if an exception occurs while processing more than one fingerprint file.Motivation and Context
Ensure recog doesn't access files and directories that are out of scope.
How Has This Been Tested?
rake tests
./bin/recog_verify
with test fingerprints copied into the XML directorypath-traversal.xml
bad-regex.xml
Test Output
Types of changes
Checklist: