Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Eltex TAU model VoIP gateway fingerprints #435

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

mkienow-r7
Copy link
Contributor

@mkienow-r7 mkienow-r7 commented Mar 12, 2022

Description

Follow-up to enhance Eltex TAU-* fingerprints introduced in #434.

  • Add os.product for Eltex TAU HTTP server fingerprint
  • Constrain model match to avoid matching non-existing models such as TAU-8.I, TAU-8.P, TAU-8.100
  • Expand regex with serial number and sofia version allow matching models that include a letter in the model number such as TAU-32M.IP
  • Expand serial number regex to include alpha characters since I located devices that included a single letter following the format VI3A###### and VI4D######.

Motivation and Context

Improved Eltex coverage.

How Has This Been Tested?

  • rake tests
  • ./bin/recog_verify

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

@mkienow-r7 mkienow-r7 requested a review from tsellers-r7 March 12, 2022 04:11
@wbowditch-r7 wbowditch-r7 requested review from wbowditch-r7 and removed request for tsellers-r7 March 29, 2022 13:56
@mkienow-r7 mkienow-r7 merged commit da2aef9 into rapid7:master Mar 29, 2022
@mkienow-r7 mkienow-r7 deleted the feature/eltex-tau-updates branch March 29, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants