Add Eltex SMG model fingerprints #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsellers-r7
reviewed
Mar 14, 2022
xml/sip_user_agents.xml
Outdated
| <example os.version="3.10.1.22">smg_pa_sip smg_pa_sip-3.10.1.22</example> | ||
| <example os.version="3.18.0.67">smg_pa_sip 3.18.0.67</example> | ||
| <param pos="0" name="os.vendor" value="Eltex"/> | ||
| <param pos="0" name="os.product" value="SMG"/> |
There was a problem hiding this comment.
This should probably be SMG firmware to maintain consistency with other embedded / networking devices.
mkienow-r7
force-pushed
the
feature/eltex-002
branch
4 times, most recently
from
ed39c60 to
847c300
Compare
mkienow-r7
force-pushed
the
feature/eltex-002
branch
from
847c300 to
6362857
Compare
mkienow-r7
changed the title
wbowditch-r7
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds new fingerprints for:
Motivation and Context
Improved coverage
How Has This Been Tested?
rake testsTypes of changes
Checklist: