Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Jupyter product fingerprints #468

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

mkienow-r7
Copy link
Contributor

@mkienow-r7 mkienow-r7 commented Jul 15, 2022

Description

Adds fingerprints for more Jupyter products (Jupyter Server, JupyterHub, BinderHub) and removes the product from the existing favicon since it is used on multiple products.

Motivation and Context

Improved coverage

How Has This Been Tested?

  • rake tests
  • ./bin/recog_verify xml/favicons.xml
  • ./bin/recog_verify xml/html_title.xml

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

@mkienow-r7 mkienow-r7 merged commit 8a13d01 into rapid7:main Aug 15, 2022
@mkienow-r7 mkienow-r7 deleted the feature/jupyter-products branch August 15, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants