Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Gunicorn with no version fingerprint #477

Merged
merged 3 commits into from
Sep 16, 2022
Merged

Add Gunicorn with no version fingerprint #477

merged 3 commits into from
Sep 16, 2022

Conversation

mkienow-r7
Copy link
Contributor

@mkienow-r7 mkienow-r7 commented Sep 8, 2022 •
edited
Loading

Description

Adds fingerprint for Gunicorn with no version.

Motivation and Context

Improved coverage

How Has This Been Tested?

  • bundle exec ./bin/recog_verify xml/http_servers.xml
  • rake tests

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

cbarnard-r7
cbarnard-r7 reviewed Sep 16, 2022
View reviewed changes
Copy link
Contributor

@cbarnard-r7 cbarnard-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious about your thoughts on version strings.

xml/http_servers.xml Show resolved Hide resolved
@mkienow-r7 mkienow-r7 force-pushed the feature/gunicorn-no-version branch from a0e3738 to 4bf111f Compare September 16, 2022 18:24
cbarnard-r7
cbarnard-r7 approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@cbarnard-r7 cbarnard-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkienow-r7 mkienow-r7 merged commit 11e2553 into rapid7:main Sep 16, 2022
@mkienow-r7 mkienow-r7 deleted the feature/gunicorn-no-version branch September 16, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbarnard-r7 cbarnard-r7 cbarnard-r7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkienow-r7 @cbarnard-r7