Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Amazon OpenSearch fingerprints #492

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

mkienow-r7
Copy link
Contributor

@mkienow-r7 mkienow-r7 commented Sep 29, 2022

Description

Adds 3 Amazon OpenSearch fingerprints.

Notes

  • <link rel="shortcut icon" href="/ui/favicons/favicon.ico"/>
$ file favicon.ico
favicon.ico: MS Windows icon resource - 3 icons, 48x48, 32 bits/pixel, 32x32, 32 bits/pixel
$ md5 favicon.ico
MD5 (favicon.ico) = 13693d9673576eee0341b65f1697a376
  • <link rel="icon" type="image/png" sizes="32x32" href="/ui/favicons/favicon-32x32.png"/>
$ file favicon-32x32.png
favicon-32x32.png: PNG image data, 32 x 32, 8-bit colormap, non-interlaced
$ md5 favicon-32x32.png
MD5 (favicon-32x32.png) = c21973630a0986ce0bd703e69ff09491
  • <link rel="icon" type="image/png" sizes="16x16" href="/ui/favicons/favicon-16x16.png"/>
$ file favicon-16x16.png
favicon-16x16.png: PNG image data, 16 x 16, 8-bit colormap, non-interlaced
$ md5 favicon-16x16.png
MD5 (favicon-16x16.png) = 91b8256f84bcb7c5c87493f652f1d191

Motivation and Context

Improved coverage

How Has This Been Tested?

  • bundle exec ./bin/recog_verify xml/favicons.xml xml/html_title.xml xml/http_wwwauth.xml
  • rake tests

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

Copy link

@egalinkin-r7 egalinkin-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -399,4 +399,4 @@
<param pos="0" name="os.certainty" value="0.1"/>
</fingerprint>

</fingerprints>
</fingerprints>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "no newline at end of file" is probably the dumbest thing Github complains about.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's helpful since you might not be aware. In many cases it is a non-issue so I understand your sentiment.

@mkienow-r7 mkienow-r7 merged commit 88671b6 into rapid7:main Oct 7, 2022
@mkienow-r7 mkienow-r7 deleted the feature/opensearch branch October 7, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants