-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DHCP fingerprints for Polycom SoundStation IP #496
Conversation
xml/dhcp_vendor_class.xml
Outdated
<param pos="0" name="hw.vendor" value="Polycom"/> | ||
<param pos="0" name="hw.family" value="SoundStation IP"/> | ||
<param pos="1" name="hw.model"/> | ||
<param pos="0" name="hw.product" value="{hw.model}"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hw.product
should be {hw.family} {hw.model}
in order to match existing CPE values.
h:polycom:soundstation_ip_4000
h:polycom:soundstation_ip_5000
h:polycom:soundstation_ip_6000
h:polycom:soundstation_ip_7000
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
907578f
to
c7dd6b4
Compare
The tests are failing since the example
|
c7dd6b4
to
238d6b7
Compare
Thanks, sorry about that. I'd seen the test failures, was wondering why (I must've forgotten to re-run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution @dmoinescu-r7!
Description
DHCP fingerprints for Polycom SoundStation IP, as observed in DHCP network traffic.
Motivation and Context
How Has This Been Tested?
Ran
recog_verify
,recog_standardize
andupdate_cpes.py
Types of changes
Checklist: