Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vaultwarden fingerprints #523

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Conversation

mkienow-r7
Copy link
Contributor

@mkienow-r7 mkienow-r7 commented Jan 9, 2023

Description

Adds two Vaultwarden, unofficial Bitwarden server, fingerprints.

Notes

Fingerprinted Vaultwarden server Version 2022.12.0.

  • <link rel="icon" type="image/png" sizes="32x32" href="images/favicon-32x32.png"/>
$ favicon-32x32.png
favicon-32x32.png: PNG image data, 32 x 32, 8-bit gray+alpha, non-interlaced
$ md5 favicon-32x32.png
MD5 (favicon-32x32.png) = 9e8ba456e7e39ea364cc538959813719
  • <link rel="icon" type="image/png" sizes="16x16" href="images/favicon-16x16.png"/>
$ file favicon-16x16.png
favicon-16x16.png: PNG image data, 16 x 16, 8-bit gray+alpha, non-interlaced
$ md5 favicon-16x16.png
MD5 (favicon-16x16.png) = 86157069c9574d4c75b907e614d6a521
  • favicon.ico matches Bitwarden's hash 2f0df01346ace9afb440288feeb5d974 so it was excluded from the fingerprint

Motivation and Context

Improved coverage

How Has This Been Tested?

  • bundle exec ./bin/recog_verify xml/favicons.xml xml/html_title.xml
  • rake tests

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

@mkienow-r7 mkienow-r7 force-pushed the feature/vaultwarden branch 2 times, most recently from 0e9ed05 to c41c099 Compare January 9, 2023 20:03
@mkienow-r7 mkienow-r7 changed the title Add vaultwarden server fingerprints Add Vaultwarden fingerprints Jan 9, 2023
xml/favicons.xml Outdated Show resolved Hide resolved
Copy link

@todb-r7 todb-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a suggestion on wording for the service description. Fix that, and ship it? Sorry I'm still getting kinda used to how github review workflow actually works.

@mkienow-r7 mkienow-r7 requested a review from todb-r7 January 10, 2023 17:05
Copy link

@todb-r7 todb-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, failed to actually approve. Go forth and merge.

@mkienow-r7 mkienow-r7 merged commit 9550efc into rapid7:main Jan 11, 2023
@mkienow-r7 mkienow-r7 deleted the feature/vaultwarden branch January 11, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants