Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cambium Wireless Access Point to dhcp_vendor_class #534

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Add Cambium Wireless Access Point to dhcp_vendor_class #534

merged 1 commit into from
Feb 2, 2023

Conversation

modoyle-r7
Copy link
Contributor

@modoyle-r7 modoyle-r7 commented Jan 27, 2023 •
edited
Loading

Description

Add Cambium Wireless Access Point to dhcp_vendor_class

Notes

Motivation and Context

Improved coverage

How Has This Been Tested?

  • ./bin/recog_verify xml/dhcp_vendor_class.xml
  • rake tests

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

@mkienow-r7
Copy link
Contributor

@modoyle-r7 Would you please update the PR description using the default PR template?

@mkienow-r7 mkienow-r7 merged commit 4667b26 into rapid7:main Feb 2, 2023
@mkienow-r7
Copy link
Contributor

Thank you for the contribution @modoyle-r7!

@modoyle-r7 modoyle-r7 deleted the morgan/dhcp_cambium_wap branch February 3, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkienow-r7 mkienow-r7 mkienow-r7 approved these changes

@dmoinescu-r7 dmoinescu-r7 Awaiting requested review from dmoinescu-r7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@modoyle-r7 @mkienow-r7