Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Atlassian Jira Service Management favicon fingerprint #543

Merged

Conversation

mkienow-r7
Copy link
Contributor

@mkienow-r7 mkienow-r7 commented Feb 8, 2023

Description

Adds Atlassian Jira Service Management favicon fingerprint.

Notes

Fingerprinted JIRA Service Management Application version 5.6.0.

  • <link rel="shortcut icon" href="/s/-8ncmrq/960000/1dlckms/_/images/fav-jsd.png">
$ file fav-jsd.png
fav-jsd.png: PNG image data, 128 x 128, 8-bit/color RGBA, non-interlaced
$ md5 fav-jsd.png
MD5 (fav-jsd.png) = 2fa69f2bc9174ffc21fc3c7925da6862

Motivation and Context

Improved coverage

How Has This Been Tested?

  • bundle exec ./bin/recog_verify xml/favicons.xml
  • rake tests

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

@todb-r7 todb-r7 self-requested a review February 8, 2023 16:34
@@ -263,6 +263,7 @@ Jenkins
JetDirect
Jetty
Jira
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is "Jira" too vague now? not a blocker but something to think about.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly - there are just additional products under the Jira family now.

@mkienow-r7 mkienow-r7 merged commit d31dddc into rapid7:main Feb 9, 2023
@mkienow-r7 mkienow-r7 deleted the feature/atlassian-jira-service-management branch February 9, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants