Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Transmission #568

Merged
merged 1 commit into from
May 1, 2023
Merged

Add Transmission #568

merged 1 commit into from
May 1, 2023

Conversation

jvoisin
Copy link
Contributor

@jvoisin jvoisin commented Apr 25, 2023

Description

Add Transmission

How Has This Been Tested?

On my LAN

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

@mkienow-r7
Copy link
Contributor

mkienow-r7 commented Apr 25, 2023 •
edited
Loading

Are there any available favicons on the web interface?

EDIT: I answered my own question, there are two! Please add a favicon hash fingerprint with these two files.

<link href="./images/favicon.ico" rel="icon" />
<link href="./images/favicon.png" rel="shortcut icon" />

@mkienow-r7
Copy link
Contributor

It looks like we could also create an HTTP server (xml/http_servers.xml) fingerprint as well. :)

$ curl -v http://localhost:9091
*   Trying 127.0.0.1:9091...
* Connected to localhost (127.0.0.1) port 9091 (#0)
> GET / HTTP/1.1
> Host: localhost:9091
> User-Agent: curl/7.87.0
> Accept: */*
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 401 Unauthorized
< Server: Transmission
...

@jvoisin
Copy link
Contributor Author

jvoisin commented Apr 27, 2023

I'd rather add the favicons in a followup PR than in this one.

mkienow-r7
mkienow-r7 reviewed Apr 28, 2023
View reviewed changes
xml/html_title.xml Outdated Show resolved Hide resolved
mkienow-r7
mkienow-r7 approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@mkienow-r7 mkienow-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @jvoisin!

@mkienow-r7 mkienow-r7 merged commit 9a6ad3a into rapid7:main May 1, 2023
@jvoisin jvoisin deleted the add_transmission branch May 1, 2023 20:33
@mkienow-r7 mkienow-r7 mentioned this pull request May 1, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkienow-r7 mkienow-r7 mkienow-r7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvoisin @mkienow-r7