Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sonarr/Radarr/Prowlarr #571

Merged
merged 1 commit into from
May 10, 2023
Merged

Add Sonarr/Radarr/Prowlarr #571

merged 1 commit into from
May 10, 2023

Conversation

jvoisin
Copy link
Contributor

@jvoisin jvoisin commented Apr 30, 2023

Description

Add Sonarr/Radarr/Prowlarr

How Has This Been Tested?

On my LAN

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

Copy link
Contributor

@mkienow-r7 mkienow-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the PR feedback please add a service.vendor param above each of the service.product with the values matching the product name. This is commonly accepted as the vendor name for many open-source projects unless NVD CPE ends up assigning a different value.

xml/http_wwwauth.xml Outdated Show resolved Hide resolved
xml/favicons.xml Show resolved Hide resolved
xml/html_title.xml Outdated Show resolved Hide resolved
xml/html_title.xml Outdated Show resolved Hide resolved
xml/favicons.xml Outdated Show resolved Hide resolved
@mkienow-r7
Copy link
Contributor

In addition to the PR feedback please add a service.vendor param above each of the service.product with the values matching the product name. This is commonly accepted as the vendor name for many open-source projects unless NVD CPE ends up assigning a different value.

This comment has not been addressed.

xml/favicons.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@mkienow-r7 mkienow-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These PR changes are almost ready! Thanks for adding service.product param to xml/favicons.xml. Those changes are still needed in xml/html_title.xml and xml/http_wwwauth.xml.

Copy link
Contributor

@mkienow-r7 mkienow-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @jvoisin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants