Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added start anchor to Meraki fingerprints #612

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

mlaskowski-r7
Copy link
Contributor

@mlaskowski-r7 mlaskowski-r7 commented Apr 9, 2024

Description

Added start anchor to Meraki fingerprints

Motivation and Context

This is to keep the newly added fingerprints in line with the project-wide standard.

How Has This Been Tested?

Tested if the original test cases are passing with: bin/recog_verify xml/snmp_sysdescr.xml

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

Copy link
Contributor

@martinvotruba-r7 martinvotruba-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adfoster-r7 adfoster-r7 requested a review from adungo-r7 April 9, 2024 15:53
@adfoster-r7 adfoster-r7 merged commit 0846bf8 into main Apr 16, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants