Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cisco CE fingerprinter #626

Merged
merged 7 commits into from
Sep 19, 2024
Merged

Conversation

atorovik-r7
Copy link
Contributor

@atorovik-r7 atorovik-r7 commented Sep 13, 2024

Description

A detailed description of your changes.
Add fingerprinting for Cisco TelePresence Cisco Collaboration Endpoint. Add new record to recog snmp. Update regex to only detect versions starting with ce.

Motivation and Context

Explanation of why these changes are being proposed, including any links to other relevant issues or pull requests.

How Has This Been Tested?

A clear and concise description of your changes were tested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

@atorovik-r7
Copy link
Contributor Author

atorovik-r7 commented Sep 13, 2024

I'm a bit confused about the versions,

in the example ce9.15.0.d97b604b745 : should be extract just ce9.15.0 or the whole string?

The versions mentioned in advisories for Cisco Collaboration Endpoint look like this 9.15.0, 9.15.10.8 etc.

@mlaskowski-r7
Copy link
Contributor

I'm a bit confused about the versions,

in the example ce9.15.0.d97b604b745 : should be extract just ce9.15.0 or the whole string?

The versions mentioned in advisories for Cisco Collaboration Endpoint look like this 9.15.0, 9.15.10.8 etc.

It's not the same but looks similar:
image
https://www.cisco.com/c/dam/en/us/td/docs/telepresence/endpoint/software/ce9/release-notes/ce-software-release-notes-ce9.pdf
image
https://help.webex.com/en-us/article/6ger7db/Release-notes-for-RoomOS-software#sx10_r_whats_new_2024__d59e98
Like after the last . we have some hash/id of the build? 🤔

@martinvotruba-r7
Copy link
Contributor

I think we should fingerprint the whole version string and leave the dealing with the hash part on the consumer of the result.

@atorovik-r7 atorovik-r7 merged commit 0ffcd3e into main Sep 19, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants