Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SIP banner to be backward compatible #628

Merged
merged 7 commits into from
Sep 18, 2024
Merged

Conversation

martinvotruba-r7
Copy link
Contributor

@martinvotruba-r7 martinvotruba-r7 commented Sep 17, 2024

Description

I am updating the SIP record for Cisco to be backward compatible.

Motivation and Context

Explanation of why these changes are being proposed, including any links to other relevant issues or pull requests.

How Has This Been Tested?

A clear and concise description of your changes were tested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

@martinvotruba-r7 martinvotruba-r7 marked this pull request as ready for review September 17, 2024 13:18
@mlaskowski-r7 mlaskowski-r7 self-requested a review September 18, 2024 08:47
@martinvotruba-r7 martinvotruba-r7 merged commit 9862c76 into main Sep 18, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants