Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vite #172

Merged
merged 20 commits into from
Dec 2, 2022
Merged

Vite #172

merged 20 commits into from
Dec 2, 2022

Conversation

royduin
Copy link
Member

@royduin royduin commented Nov 23, 2022

No description provided.

royduin and others added 8 commits August 26, 2022 15:47
@royduin
Replaced Laravel Mix with Vite
912b58b
@StyleCIBot
Apply fixes from StyleCI
6b6edc0
@royduin
Do not test with prefer-lowest as its missing functionality
5f882a3
@royduin
Merge branch 'vite' of github.com:rapidez/core into vite
1b2b96d
@indykoning
Vue-slider-component fix (#157)
c6c1323
@indykoning
Fix errors for CategoryFilter component (#158)
6911f8d
@indykoning
Merge branch 'master' of github.com:rapidez/core into vite
4e62da5
@indykoning
Use Laravel vite directive to add preloads (#171)
40e3f47 
* Use alias to make sure it resolves to the parent node_modules

* import path

* No longer require node_modules prefix for development

* Fix missing process from reactivesearch

* Ensure listing bundle including imports are preloaded

* Fix mistake in merge

* Revert "Fix mistake in merge"

This reverts commit c416ce7.
@royduin
Copy link
Member Author

royduin commented Nov 23, 2022

Maybe we should revert the .github/workflows/phpunit.yml changes and raise the dependencies in the composer.json. It was removed to get rid of the errors from Vite helpers functions which didn't exist.

@royduin
Copy link
Member Author

royduin commented Nov 23, 2022

Why are the Dusk tests failing?

@indykoning
Copy link
Member

It seems almost random wether the dusk tests succeed or fail during testing. Is there a chance that the pipeline does not wait for the indexers to have finished and thus the table might or might not exist depending on the speed of the indexer?

@indykoning
Copy link
Member

I've found the problem. We're too quick with vite! 🎉
The flat indexer is not done by the time the styling is compiled and the tests are executing. I'll have to build in a step to wait until the flat table is available to us

@indykoning
Copy link
Member

Tests are now functioning properly after adding a wait until the catalog_product_flat_1 table to become available.
The only failing test seems to be incorrect as the screenshot in the artifact does in fact contain "Partytime!"

royduin
royduin commented Dec 2, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@royduin royduin merged commit 7100cf6 into master Dec 2, 2022
@royduin royduin deleted the vite branch December 2, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@indykoning indykoning indykoning left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@royduin @indykoning @StyleCIBot