Price component #362
Draft
Price component #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jade-GG
reviewed
Oct 18, 2023
Jade-GG
requested changes
Oct 23, 2023
| if (['shipping', 'billing'].includes(window.config?.tax?.calculation.based_on)) { | ||
| country_id = window.app?.$data?.checkout?.[window.config?.tax?.calculation.based_on + '_address']?.country_id || country_id | ||
| region_id = window.app?.$data?.checkout?.[window.config?.tax?.calculation.based_on + '_address']?.region_id || region_id | ||
| postcode = window.app?.$data?.checkout?.[window.config?.tax?.calculation.based_on + '_address']?.postcode || postcode |
There was a problem hiding this comment.
let basedOn = window.app?.$data?.checkout?.[window.config?.tax?.calculation.based_on + '_address']And then use that instead of repeating it 3 times, would probably be much cleaner here.
| ->where(fn ($query) => $query | ||
| ->where('all_groups', 1) | ||
| ->orWhere('customer_group_id', auth('magento-customer')->user()?->group_id ?? 0) | ||
| ); |
Jade-GG
reviewed
Apr 25, 2024
|
|
||
| price() { | ||
| return this.calculatePrice(this.options) | ||
| }, |
There was a problem hiding this comment.
This needs to be thought out again, Magento doesn't work with prices this way.
Prices are calculated as follows: Final Price=Min(Regular(Base) Price, Group(Tier) Price, Special Price, Catalog Price Rule) + Sum(Min Price per each required custom option)
Note that prices are clamped to a minimum of 0 before and after the custom options are added. Also, the price gets rounded before getting multiplied by the qty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking: