Watch currentShippingMethod instead of shipping_method #414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CurrentShippingMethod will update on changes in
checkout.shipping_methods
andcheckout.shipping_method
Because
checkout.shipping_method
was being watched whilecurrentShippingMethod
is being used inselectShippingMethod()
, a race condition could occur wherecheckout.shipping_methods
was empty whilecheckout.shipping_method
was filled.Resulting in
currentShippingMethod.carrier_code
throwing an error breaking theshipping-information
API request.By watching
currentShippingMethod
we are also waiting for theshipping_methods
to be filled before attempting to update the shipping method