Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed parent product link for configurable products #486

Merged
merged 1 commit into from
May 3, 2024

Conversation

indykoning
Copy link
Member

@indykoning indykoning commented May 2, 2024

Without this the product is not linked to it's parent, meaning that product options of the parent aren't considered.
Nor are the selected configurable options shown in the cart as you've added a simple product instead of a configurable product

https://developer.adobe.com/commerce/webapi/graphql/schema/cart/mutations/add-products/#specify-the-sku-with-selected-options

@indykoning indykoning requested a review from royduin as a code owner May 2, 2024 15:31
@royduin
Copy link
Member

royduin commented May 2, 2024

Are we sure this time? #461

cc @BobWez98

@royduin royduin requested a review from BobWez98 May 2, 2024 17:04
@BobWez98
Copy link
Collaborator

BobWez98 commented May 3, 2024

I think i made a mistake back when i changed it to SimpleProduct. We were thinking back then every variant was in stock because the disabledOptions weren't working properly. I tested this and i agree 👍 @royduin

@royduin royduin merged commit 50df886 into master May 3, 2024
18 checks passed
@royduin royduin deleted the fix/configurable-options-display branch May 3, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants