Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Enable highlighting in autocomplete products #496

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

Jade-GG
Copy link
Collaborator

@Jade-GG Jade-GG commented May 14, 2024

This PR enables highlighting from elasticsearch in the product listing, which puts the <mark></mark> tags around matched text on every product title. This was already enabled by default on categories and any other extra indices, so this is for consistency.

@royduin
Copy link
Member

royduin commented May 14, 2024

Could you provide some more info so @jordythevulder can make a decision if we want this by default on all shops?

@royduin royduin merged commit 4c68819 into master May 15, 2024
17 of 18 checks passed
@royduin royduin deleted the Jade-GG-patch-5 branch May 15, 2024 07:35
@royduin
Copy link
Member

royduin commented May 15, 2024

It's used on everything but the products; so yes: we want this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants