Add backorders to rapidez 2.0 #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indykoning
requested changes
Jun 17, 2024
resources/views/cart/item.blade.php
Outdated
| <div v-if="item.backorder_count" class="flex gap-2"> | ||
| <x-heroicon-o-exclamation-circle class="mt-px w-5" /> | ||
| <span> | ||
| <template v-if="item.backorder_count == item.qty"> |
There was a problem hiding this comment.
It looks like this if case is flipped, or could be item.backorder_count < item.qty
There was a problem hiding this comment.
I'd say the other way around, if the qty is the stock and it's lower than the backorder count, there are products to be backordered.
indykoning
reviewed
Jun 18, 2024
| @@ -3,6 +3,9 @@ total_quantity | |||
| items { | |||
| id | |||
| quantity | |||
| @if (Rapidez::checkCompadreVersion('0.0.4')) | |||
There was a problem hiding this comment.
It's unfortunate that it does not match the current release but it should match the version of the module
https://github.com/rapidez/magento2-compadre/blob/master/src/etc/module.xml#L4
not the release
resources/views/cart/item.blade.php
Outdated
| <div v-if="item.qty_backordered" class="flex gap-2"> | ||
| <x-heroicon-o-exclamation-circle class="mt-px w-5" /> | ||
| <span> | ||
| <template v-if="item.qty_backordered > item.qty"> |
There was a problem hiding this comment.
I'm not sure of the format qty_backordered comes in so i could be wrong.
Wouldn't it be impossible for the qty_backordered to be higher than the qty ordered?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.