Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Slideover header button fix #554

Merged
merged 1 commit into from
Sep 3, 2024
Merged

[2.x] Slideover header button fix #554

merged 1 commit into from
Sep 3, 2024

Conversation

Jade-GG
Copy link
Collaborator

@Jade-GG Jade-GG commented Sep 3, 2024

The back arrow button used id instead of for and used a weird attributes merge (that didn't include the class in the merge, which broke it). There may have been a use case for it while developing this slideover, but it sure as heck isn't used now.

@royduin
Copy link
Member

royduin commented Sep 3, 2024

So we don't want any attribute merging?

@Jade-GG
Copy link
Collaborator Author

Jade-GG commented Sep 3, 2024

So we don't want any attribute merging?

Not on that label, no. This header is used via an @include in the index, where $attributes is actually used one DOM level up for the styling of the whole slideover.

@royduin royduin merged commit bd86864 into master Sep 3, 2024
18 checks passed
@royduin royduin deleted the Jade-GG-patch-4 branch September 3, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants