Colors changes #580
Open
Colors changes #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimmyHoenderdaal
requested review from
royduin and
indykoning
as code owners
royduin
reviewed
Sep 24, 2024
| @@ -1,3 +1,3 @@ | |||
| <x-rapidez::button.base {{ $attributes->class('bg-primary text-primary-text') }}> | |||
| <x-rapidez::button.base {{ $attributes->class('bg-primary text-white') }}> | |||
There was a problem hiding this comment.
So when the primary color is a light color; the text is unreadable and you've to override this template?
There was a problem hiding this comment.
Yes, buttons are always custom in projects. there's not much to override either since its only classes you would add to a base.blade.php or index.blade.php
royduin
reviewed
Sep 24, 2024
Comment on lines
+25
to
+29
| inactive: { | ||
| DEFAULT: 'rgb(var(--inactive) / <alpha-value>)', // Inactive text color | ||
| 100: 'rgb(var(--inactive-100) / <alpha-value>)', // Background color | ||
| 110: 'rgb(var(--inactive-110) / <alpha-value>)', // Border color | ||
| }, |
There was a problem hiding this comment.
Inactive implies it's used for inactive states but it's used for backgrounds, borders, etc
There was a problem hiding this comment.
It's because the inactive color is always some sort of gray, the color we use for backgrounds and borders is also always some sort of gray. Thats why we call them this way
royduin
requested changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes & adds some colors that we use regularly
This is blocking rapidez/account#50